fix mult() inconsistency: make 3x3 and NxN use left-multiplication like 4x4#8947
Closed
vamshi567bh wants to merge 0 commit into
Closed
fix mult() inconsistency: make 3x3 and NxN use left-multiplication like 4x4#8947vamshi567bh wants to merge 0 commit into
vamshi567bh wants to merge 0 commit into
Conversation
vamshi567bh
force-pushed
the
clean-matrix-fix
branch
from
74c4ce1 to
e1c67e4
Compare
Author
|
@davepagurek please review thanks! |
19 tasks
Author
|
processing/p5.js-website#1460 related |
Contributor
|
Does this actually address #8940 ? i.e. does it go through the mult3x3 or multNxN code paths there? It sounds like if these methods have inconsistent sidedness with 4x4 matrices, that it'd maybe be a separate issue. Before continuing down this path it would be good to raise an issue for it with a sketch showing the difference between e.g. a translate applied onto a scale via 2d and 3d affine matrices to see if it's different. |
vamshi567bh
force-pushed
the
clean-matrix-fix
branch
3 times, most recently
from
16d910e to
331a7e1
Compare
vamshi567bh
force-pushed
the
clean-matrix-fix
branch
from
331a7e1 to
71d062a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Makes #mult3x3 and #multNxN consistent with #mult4x4 by using left-multiplication (this = arg * this) instead of right-multiplication (this = this * arg).
PR Checklist